From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Drop unused drm_device_class_(un)register API Date: Tue, 05 May 2026 11:46:02 +1000 Message-ID: In-Reply-To: <20260429085726.69842-1-tvrtko.ursulin@igalia.com> References: <20260429085726.69842-1-tvrtko.ursulin@igalia.com> <20260429085726.69842-1-tvrtko.ursulin@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** - The removal of `drm_class_device_register()` and `drm_class_device_unregi= ster()` from `drm_sysfs.c` is complete =E2=80=94 both function bodies and t= heir `EXPORT_SYMBOL_GPL` lines are removed. - The header `drm_sysfs.h` correctly removes both function declarations and= the `struct device` forward declaration, which was only needed for those f= unction prototypes. - The remaining declarations in `drm_sysfs.h` (`drm_sysfs_hotplug_event`, `= drm_sysfs_connector_hotplug_event`, `drm_sysfs_connector_property_event`) u= se `struct drm_device`, `struct drm_connector`, and `struct drm_property` = =E2=80=94 none require `struct device`, so removing that forward declaratio= n is safe. **Nit (commit message):** The subject says `drm_device_class_(un)register` = but the actual function names are `drm_class_device_register` / `drm_class_= device_unregister` =E2=80=94 the word order is swapped. This is a minor cos= metic issue in the subject line: ``` Subject: [PATCH] drm: Drop unused drm_device_class_(un)register API ``` Should be: ``` Subject: [PATCH] drm: Drop unused drm_class_device_(un)register API ``` **No other issues.** The patch is minimal, correct, and safe to merge (with= optionally fixing the subject typo). --- Generated by Claude Code Patch Reviewer