From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE Date: Tue, 05 May 2026 11:36:17 +1000 Message-ID: In-Reply-To: <20260429140024.192432-1-arnd@kernel.org> References: <20260429140024.192432-1-arnd@kernel.org> <20260429140024.192432-1-arnd@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Subject line typo:** The subsystem prefix is `drm/ipv3` but should be `dr= m/ipuv3` (missing the "u"). The Kconfig and directory are both `ipuv3`. **Commit message:** Clear and well-structured. The Kconfig dependency resol= ution output pasted in the body immediately makes the problem obvious: ``` Depends on [n]: HAS_IOMEM [=3Dy] && DRM [=3Dy] && DRM_BRIDGE [=3Dy] && OF [= =3Dn] Selected by [y]: - DRM_IMX_PARALLEL_DISPLAY [=3Dy] && ... - DRM_IMX_LDB [=3Dy] && ... ``` **Code changes =E2=80=94 correct and minimal:** ```diff config DRM_IMX_PARALLEL_DISPLAY tristate "Support for parallel displays" depends on DRM_IMX + depends on OF ``` ```diff config DRM_IMX_LDB tristate "Support for LVDS displays" depends on DRM_IMX depends on COMMON_CLK + depends on OF ``` Both additions are correct. The dependency chain that enables the `OF=3Dn` = path is: `COMPILE_TEST` =E2=86=92 `IMX_IPUV3_CORE` =E2=86=92 `DRM_IMX` =E2= =86=92 `DRM_IMX_PARALLEL_DISPLAY`/`DRM_IMX_LDB` =E2=86=92 (selects) `DRM_OF= _DISPLAY_MODE_BRIDGE`, and `DRM_OF_DISPLAY_MODE_BRIDGE` depends on `OF`. Ad= ding `depends on OF` to the selectors prevents the broken configuration. **Minor observations:** 1. `DRM_IMX_HDMI` in the same file already has `depends on DRM_IMX && OF`, = so there is precedent for per-sub-option OF dependencies here. 2. An alternative approach would be to add `depends on OF` to `DRM_IMX` its= elf, which would cascade to all sub-options. This would be cleaner if all s= ub-options require OF (which seems likely for an i.MX DRM driver), but woul= d also affect `DRM_IMX_TVE` which currently has no OF dependency. The per-o= ption approach in this patch is the safer, more targeted fix. **Verdict:** The fix is correct. The subject typo (`ipv3` =E2=86=92 `ipuv3`= ) should be fixed before applying. --- Generated by Claude Code Patch Reviewer