From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: clean up reversed type specifiers in dml2_core Date: Thu, 30 Apr 2026 10:53:42 +1000 Message-ID: In-Reply-To: <20260429210209.42737-1-adri.vero.dev@gmail.com> References: <20260429210209.42737-1-adri.vero.dev@gmail.com> <20260429210209.42737-1-adri.vero.dev@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Changes in `dml2_core_dcn4.c`:** The two viewport height casts are fixed: ```c - phantom->composition.viewport.plane0.height =3D (long int unsigned) math_= min2(...) + phantom->composition.viewport.plane0.height =3D (unsigned long) math_min2= (...) ``` And the local variable declaration: ```c - int unsigned odm_count, num_odm_output_segments, dpp_count; + unsigned int odm_count, num_odm_output_segments, dpp_count; ``` Both correct. The `height` field is `unsigned long` per `dml_top_display_cf= g_types.h:223`, so the cast target type matches. **Changes in `dml2_core_utils.c`:** Return type and local variable fix: ```c -int unsigned dml2_core_utils_get_gfx_version(enum dml2_swizzle_mode sw_mod= e) +unsigned int dml2_core_utils_get_gfx_version(enum dml2_swizzle_mode sw_mod= e) { - int unsigned version =3D 0; + unsigned int version =3D 0; ``` Correct. Parameter type fix with line-length reformatting: ```c -unsigned int dml2_core_util_get_num_active_pipes(int unsigned num_planes, = const struct core_display_cfg_support_info *cfg_support_info) +unsigned int +dml2_core_util_get_num_active_pipes(unsigned int num_planes, + const struct core_display_cfg_support_info *cfg_support_info) ``` Correct, and the reformatting is welcome since the old line was well over 8= 0 columns. Same viewport height cast fixes as in `dml2_core_dcn4.c` =E2=80=94 this is = a duplicate `create_phantom_plane_from_main_plane` function (one static cop= y per file). Both fixed consistently. **Changes in `dml2_core_utils.h`:** Declarations updated to match the `.c` changes for both `dml2_core_util_get= _num_active_pipes` and `dml2_core_utils_get_gfx_version`. Consistent with t= he source. **Minor observation:** The two separate static copies of `create_phantom_pl= ane_from_main_plane` in `dml2_core_dcn4.c` and `dml2_core_utils.c` are a pr= e-existing code duplication issue, not introduced by this patch. **Reviewed-by worthy:** Yes. No issues. --- Generated by Claude Code Patch Reviewer