From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: leds: backlight: document the SY7758 6-channel High Efficiency LED Driver Date: Tue, 05 May 2026 10:44:01 +1000 Message-ID: In-Reply-To: <20260430-topic-sm8650-ayaneo-pocket-s2-sy7758-v2-1-308140640de9@linaro.org> References: <20260430-topic-sm8650-ayaneo-pocket-s2-sy7758-v2-0-308140640de9@linaro.org> <20260430-topic-sm8650-ayaneo-pocket-s2-sy7758-v2-1-308140640de9@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Overall**: Clean binding. Already has a Reviewed-by from Krzysztof Kozlowski. Minor suggestions only. **Good:** - Correctly references `common.yaml#` via `allOf`, inheriting `default-brightness` and `max-brightness` properties - Uses `unevaluatedProperties: false` properly - Example is well-formed **Minor note:** The binding inherits `default-brightness` and `max-brightness` from `common.yaml`, but the driver (patch 2) doesn't read these properties. This means they'll be accepted in DT but silently ignored by the driver, which could be confusing. --- --- Generated by Claude Code Patch Reviewer