From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel: Add Novatek NT37705 Date: Tue, 05 May 2026 09:22:46 +1000 Message-ID: In-Reply-To: <20260501-fp6-panel-v1-1-e09cb05651cc@fairphone.com> References: <20260501-fp6-panel-v1-0-e09cb05651cc@fairphone.com> <20260501-fp6-panel-v1-1-e09cb05651cc@fairphone.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The binding is clean and follows existing patterns. One concern: **Compatible property uses `contains` instead of `const` or `items`:** ```yaml compatible: contains: const: boe,bj631jhm-t71-d900 ``` Using `contains` means the compatible property is valid as long as `boe,bj631jhm-t71-d900` appears *anywhere* in the list, with any number of other strings. For a binding with a single known panel, the conventional pattern is either: ```yaml compatible: const: boe,bj631jhm-t71-d900 ``` or, if you intend to support future panels sharing the NT37705 IC as fallback compatibles: ```yaml compatible: items: - enum: - boe,bj631jhm-t71-d900 - const: novatek,nt37705 ``` Compare with `novatek,nt37801.yaml` which uses `oneOf` with explicit `items` lists. The DT binding maintainers may flag this. Otherwise the binding looks correct -- three supplies (vddio, dvdd, vci), reset-gpios, reg, and port are all required and match the driver. --- Generated by Claude Code Patch Reviewer