From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: renesas: rz-du: mipi-dsi: drop duplicate platform_set_drvdata() call Date: Tue, 05 May 2026 09:31:02 +1000 Message-ID: In-Reply-To: <20260501080818.955914-1-john.madieu.xa@bp.renesas.com> References: <20260501080818.955914-1-john.madieu.xa@bp.renesas.com> <20260501080818.955914-1-john.madieu.xa@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: OK** Confirmed in the source tree that there are indeed two identical calls: - Line 1405: `platform_set_drvdata(pdev, dsi);` (right after `devm_drm_brid= ge_alloc`) - Line 1444: `platform_set_drvdata(pdev, dsi);` (after reset controller acq= uisition) The `dsi` pointer is not reassigned between the two calls, and no runtime c= allbacks that read driver data can fire before probe returns, so removing e= ither call is safe. The v2 decision to drop the *first* occurrence (line 14= 05) rather than the second is fine =E2=80=94 it keeps the call closer to th= e `pm_runtime_enable()` at line 1446, which is the first point where PM cal= lbacks could theoretically be invoked. **Nit (commit message):** "occurence" in the v2 changelog should be "occurr= ence", but this is below the `---` line so it won't be in the git history. **No functional concerns.** This is a clean one-line removal with no behavi= oral impact. --- Generated by Claude Code Patch Reviewer