From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages Date: Tue, 05 May 2026 09:13:58 +1000 Message-ID: In-Reply-To: <20260501171333.4044699-1-shuicheng.lin@intel.com> References: <20260501171333.4044699-1-shuicheng.lin@intel.com> <20260501171333.4044699-1-shuicheng.lin@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** The change is correct. Looking at the kernel tree, `struct= drm_gpusvm_pages_flags` already has its own complete kernel-doc block (lin= es 108=E2=80=93117 in the header) documenting all five bit-flags (`@migrate= _devmem`, `@unmapped`, `@partial_unmap`, `@has_devmem_pages`, `@has_dma_map= ping`) plus `@__flags`. The dotted `@flags.*` entries in `struct drm_gpusvm= _pages` were purely redundant. **Replacement text is appropriate:** The new line: ``` * @flags: Flags for the range; see &struct drm_gpusvm_pages_flags ``` uses the standard kernel-doc cross-reference syntax (`&struct ...`), which = will produce a proper hyperlink in generated documentation. This is the idi= omatic way to handle named sub-struct types. **Minor nit (non-blocking):** The original `@flags` description said "Flags= for range" and the replacement says "Flags for the range". This is fine = =E2=80=94 actually slightly more grammatical. However, the canonical doc in= `struct drm_gpusvm_pages_flags` itself uses "pages" terminology (e.g., "Fl= ag indicating if the pages has been unmapped"), while this says "range". Bo= th are arguably correct since `drm_gpusvm_pages` is embedded in `drm_gpusvm= _range`, but "Flags for the pages" would be more consistent with the naming= of both the containing struct (`drm_gpusvm_pages`) and the flags struct (`= drm_gpusvm_pages_flags`). This is purely cosmetic and not worth blocking on. **No other concerns.** The diff is minimal, touches only documentation, and= introduces no functional change. Reviewed-by worthy as-is. --- Generated by Claude Code Patch Reviewer