From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages Date: Tue, 05 May 2026 09:12:49 +1000 Message-ID: In-Reply-To: <20260501174435.4053381-1-shuicheng.lin@intel.com> References: <20260501174435.4053381-1-shuicheng.lin@intel.com> <20260501174435.4053381-1-shuicheng.lin@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** The distinction between anonymous structs (where dot= ted notation is valid) and named struct types (where it isn't) is correctly= identified. Compare with `struct drm_gpusvm_notifier` in the same file (li= ne ~96 in the current tree), which uses `@flags.removed` =E2=80=94 and that= one is correct because `flags` there is an anonymous `struct { u32 removed= : 1; }`, not a named type. **The replacement line is well-formed:** ``` - * @flags: Flags for range - * @flags.migrate_devmem: Flag indicating whether the range can be migrate= d to device memory - * @flags.unmapped: Flag indicating if the range has been unmapped - * @flags.partial_unmap: Flag indicating if the range has been partially u= nmapped - * @flags.has_devmem_pages: Flag indicating if the range has devmem pages - * @flags.has_dma_mapping: Flag indicating if the range has a DMA mapping + * @flags: Flags for the range; see &struct drm_gpusvm_pages_flags ``` The `&struct drm_gpusvm_pages_flags` syntax is standard kernel-doc cross-re= ferencing and will produce a hyperlink in the generated documentation. **One very minor nit:** The wording changed from "Flags for range" to "Flag= s for the range" (added "the"). Fine, slightly better English. **No issues found.**=20 Reviewed-by worthy. --- Generated by Claude Code Patch Reviewer