From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gpusvm: Drop redundant @flags.* kernel-doc on struct drm_gpusvm_pages Date: Tue, 05 May 2026 09:11:20 +1000 Message-ID: In-Reply-To: <20260501175956.4054088-1-shuicheng.lin@intel.com> References: <20260501175956.4054088-1-shuicheng.lin@intel.com> <20260501175956.4054088-1-shuicheng.lin@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** The change is correct. Comparing with the kernel tree, `dr= m_gpusvm_notifier` (line 96-106) uses an anonymous `struct { u32 removed : = 1; } flags;` where dotted `@flags.removed` notation *is* appropriate. But `= drm_gpusvm_pages` (line 147-152) uses the named type `struct drm_gpusvm_pag= es_flags flags;`, which the kernel-doc parser does not flatten =E2=80=94 so= the `@flags.*` entries are indeed excess members that trigger warnings. **The replacement line:** ``` * @flags: Flags for the range; see &struct drm_gpusvm_pages_flags ``` This correctly uses kernel-doc's `&struct` cross-reference syntax and provi= des a pointer to the canonical documentation. **Minor observations:** 1. The patch context lines include `@state` and `@state_offset` fields that= don't exist in the current drm-next tree, confirming this targets drm-misc= (as stated in the v2 changelog). This is fine =E2=80=94 the patch will app= ly cleanly on its intended base. 2. The commit message is well-written: it explains the root cause (named vs= anonymous struct semantics in kernel-doc), quotes the specific warnings, a= nd states "No functional change." 3. The `Assisted-by: Claude:claude-opus-4.6` tag =E2=80=94 v3 of this patch= specifically corrects this tag formatting, which is a reasonable thing to = fix. **Reviewed-by worthy:** Yes, this is a clean, correct documentation fix. No= concerns. --- Generated by Claude Code Patch Reviewer