From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/nouveau/kms/nvd9-: Remove unused header in crc.c Date: Tue, 05 May 2026 09:07:11 +1000 Message-ID: In-Reply-To: <20260501215703.820656-2-lyude@redhat.com> References: <20260501215703.820656-2-lyude@redhat.com> <20260501215703.820656-2-lyude@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Clean** The patch removes the unused include: ```c -#include "wndw.h" ``` I verified that `crc.c` contains zero references to any symbol exported by = `wndw.h` =E2=80=94 no use of `struct nv50_wndw`, `struct nv50_wndw_func`, `= nv50_wndw()`, or any of the `wndwc*` / `base507c*` function declarations. T= he remaining includes (`nouveau_drv.h`, `core.h`, `head.h`, `handles.h`, `c= rc.h`) are sufficient for everything `crc.c` needs. **Minor nit on the subject line:** The subject says "nvd9-" (suggesting GF1= 19+), but the file path is `dispnv50/` which covers NV50 and later. The "nv= d9-" scope qualifier in the subject seems to refer to the CRC feature's har= dware support range rather than the file location, which is fine, but could= be slightly confusing since the file itself is shared across the dispnv50 = code. **No issues found.** Reviewed-by worthy as-is. --- Generated by Claude Code Patch Reviewer