From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: boe-tv101wum-nl6: restore MODE_LPM after sending disable cmds Date: Tue, 05 May 2026 08:45:16 +1000 Message-ID: In-Reply-To: <20260503091708.1079962-1-zhengxingda@iscas.ac.cn> References: <20260503091708.1079962-1-zhengxingda@iscas.ac.cn> <20260503091708.1079962-1-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **The bug:** In `boe_panel_disable()` (line 1322 of the current tree), the = driver clears `MIPI_DSI_MODE_LPM`: ```c boe->dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; ``` This is intentional =E2=80=94 the display-off and sleep-enter DCS commands = should be sent in HS mode. However, the flag is never restored, so on the n= ext prepare/init cycle (which doesn't independently set LPM), commands are = sent in HS mode when LP mode is expected. **The fix is correct.** The patch adds: ```c boe->dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; ``` This matches the established pattern in other panel drivers. The `Fixes:` t= ag and `Cc: stable` are appropriate since this is a clear regression-fix fo= r the original driver commit. **Minor placement concern:** The restore is inserted *between* `mipi_dsi_dc= s_enter_sleep_mode_multi()` and the `mipi_dsi_msleep(&ctx, 150)` delay. Mos= t other drivers that follow this pattern (e.g., `panel-boe-bf060y8m-aj0` at= line 102) restore LPM *after* the final delay in the off sequence. In this= driver the `mipi_dsi_msleep` is a multi-context sleep, which checks `ctx.a= ccum_err` but doesn't issue DSI commands, so the placement is functionally = harmless. Still, placing the restore **after** the `mipi_dsi_msleep()` and = before the `return` would be slightly cleaner =E2=80=94 it keeps all HS-mod= e operations (including the sleep delay that's part of the disable sequence= ) grouped together, and restores LPM only once the disable sequence is trul= y complete. This is a style nit, not a correctness issue. **Commit message:** Clear, explains the problem, the fix, and the real-worl= d impact (error messages on mt8183-kukui-kodama-sku32). Well written. **Overall: Looks good.** Reviewed-by worthy, optionally with the minor sugg= estion to move the restore after the msleep. --- Generated by Claude Code Patch Reviewer