From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel: document the Renesas R63419 based dual-DSI video mode Display Panels Date: Tue, 05 May 2026 08:29:50 +1000 Message-ID: In-Reply-To: <20260504-topic-sm8650-ayaneo-pocket-s2-r63419-v3-1-9f61cf24aebf@linaro.org> References: <20260504-topic-sm8650-ayaneo-pocket-s2-r63419-v3-0-9f61cf24aebf@linaro.org> <20260504-topic-sm8650-ayaneo-pocket-s2-r63419-v3-1-9f61cf24aebf@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch adds a YAML DT binding for the R63419-based panels. Generally well-structured. **Issue: Swapped vsp/vsn supply phandle names in the example** ```yaml vsn-supply = <&vdd_5v0_pos>; vsp-supply = <&vdd_5v0_neg>; ``` VSP is "Voltage Supply Positive" and VSN is "Voltage Supply Negative". The example connects VSP to `vdd_5v0_neg` and VSN to `vdd_5v0_pos`. While phandle names are arbitrary, this is confusing and likely copy-paste error. Should be: ```yaml vsp-supply = <&vdd_5v0_pos>; vsn-supply = <&vdd_5v0_neg>; ``` **Minor: `ports` could specify the port layout** The binding declares `ports: true` but doesn't describe the expected port structure (port@0 = primary DSI, port@1 = secondary DSI). Other dual-DSI bindings sometimes specify this. The example makes it clear, but a schema-level description of the two ports would be more robust. **Minor: `reg` not listed as required** DSI panel nodes typically require `reg`. It's defined in the `properties` section but not listed in `required`. This may be inherited from `panel-common.yaml`, but worth verifying. --- Generated by Claude Code Patch Reviewer