public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Don't use UTS_RELEASE directly
Date: Tue, 05 May 2026 08:34:38 +1000	[thread overview]
Message-ID: <review-patch1-20260504073422.1130008-2-u.kleine-koenig@baylibre.com> (raw)
In-Reply-To: <20260504073422.1130008-2-u.kleine-koenig@baylibre.com>

Patch Review

**Verdict: Looks good / No issues.**

The patch makes three changes:

1. **Removes `#include <generated/utsrelease.h>`** — this header provided the `UTS_RELEASE` macro, no longer needed.

2. **Adds `#include <linux/utsname.h>`** — provides `init_utsname()`. Placed in correct alphabetical order among the `<linux/...>` includes.

3. **Replaces the macro usage:**
```c
-			VMWGFX_DRIVER_PATCHLEVEL, UTS_RELEASE);
+			VMWGFX_DRIVER_PATCHLEVEL, init_utsname()->release);
```

This is the only usage of `UTS_RELEASE` in the file, so the include swap is complete. The `init_utsname()->release` accessor returns the same NUL-terminated string at runtime, so the `%s` format specifier in `vmw_host_printf` works identically.

The pattern is already established in other DRM drivers — `drivers/gpu/drm/i915/i915_gpu_error.c` and `drivers/gpu/drm/xe/xe_guc_log.c` both use `init_utsname()->release` the same way.

The commit message clearly explains the motivation (build reproducibility / avoiding unnecessary recompilation) and the cover letter honestly notes that dropping the version string entirely would be an alternative, which shows good judgment in choosing the less disruptive option.

**Reviewed-by worthy.** No correctness, style, or design concerns.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-04 22:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04  7:34 [PATCH] drm/vmwgfx: Don't use UTS_RELEASE directly Uwe Kleine-König (The Capable Hub)
2026-05-04 22:34 ` Claude Code Review Bot [this message]
2026-05-04 22:34 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260504073422.1130008-2-u.kleine-koenig@baylibre.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox