From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Disable scrambler feature when not supported Date: Tue, 05 May 2026 07:58:54 +1000 Message-ID: In-Reply-To: <20260504191059.275928-2-jonas@kwiboo.se> References: <20260504191059.275928-1-jonas@kwiboo.se> <20260504191059.275928-2-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward fix. When the SCDC path is not taken (because scrambling is not needed or supported), the scrambler control register is explicitly cleared. This handles the hotplug scenario described in the commit message correctly. ```c + } else if (hdmi->version >= 0x200a) { + hdmi_writeb(hdmi, 0, HDMI_FC_SCRAMBLER_CTRL); } ``` The version check `>= 0x200a` is consistent with how the existing code gates SCDC features. Looks correct. Has Reviewed-by. --- Generated by Claude Code Patch Reviewer