From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: mayqueen,pixpaper: add pixpaper-426m Date: Thu, 07 May 2026 13:55:15 +1000 Message-ID: In-Reply-To: <20260506-bar-v1-1-12195406f4ef@gmail.com> References: <20260506-bar-v1-0-12195406f4ef@gmail.com> <20260506-bar-v1-1-12195406f4ef@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch extends the existing binding to add the `mayqueen,pixpaper-426m` compatible string. **Generally OK**, but a few observations: 1. **Good**: Extending the existing binding rather than creating a new one is the right approach since the DT interface (SPI + 3 GPIOs) is identical. 2. **Missing `spi-max-frequency` in the example**: The example DT node specifies `spi-max-frequency = <1000000>` which matches the driver default, but the schema itself doesn't constrain the maximum. This is consistent with the existing binding, so it's fine, but a `maximum` constraint in the schema would be a nice addition for documentation purposes. 3. **Minor**: The new example is clean and consistent with the existing one. No issues. --- --- Generated by Claude Code Patch Reviewer