From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: media: iris: retrieve UBWC platform configuration
Date: Thu, 07 May 2026 12:40:16 +1000
Message-ID: <review-patch1-20260507-iris-ubwc-v5-1-e9a3aee53c49@oss.qualcomm.com>
In-Reply-To: <20260507-iris-ubwc-v5-1-e9a3aee53c49@oss.qualcomm.com>
References: <20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com> <20260507-iris-ubwc-v5-1-e9a3aee53c49@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

This patch adds the `QCOM_UBWC_CONFIG` Kconfig dependency, a forward declaration of `struct qcom_ubwc_cfg_data` in `iris_core.h`, and retrieves the config at probe time.

The implementation is straightforward and correct:

```c
core->ubwc_cfg = qcom_ubwc_config_get_data();
if (IS_ERR(core->ubwc_cfg))
    return PTR_ERR(core->ubwc_cfg);
```

**Minor nit:** Modern kernel probe functions prefer `dev_err_probe()` for error handling, which silences `EPROBE_DEFER` noise and provides a consistent error message for genuine failures:

```c
if (IS_ERR(core->ubwc_cfg))
    return dev_err_probe(core->dev, PTR_ERR(core->ubwc_cfg),
                         "failed to get UBWC config\n");
```

The `select QCOM_UBWC_CONFIG` in Kconfig ensures the real implementation is compiled in, avoiding the stub that always returns `-EOPNOTSUPP`.

No other issues.

---
Generated by Claude Code Patch Reviewer