From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Disable scrambler feature when not supported Date: Sat, 16 May 2026 16:21:41 +1000 Message-ID: In-Reply-To: <20260510124111.1226584-2-jonas@kwiboo.se> References: <20260510124111.1226584-1-jonas@kwiboo.se> <20260510124111.1226584-2-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good fix. When hotplugging from an HDMI 2.0 sink (4K@60) to an HDMI 1.4 sink, the scrambler was left enabled, causing a blank screen. The fix writes `0` to `HDMI_FC_SCRAMBLER_CTRL` when SCDC is not supported (the `else` branch of the SCDC check): ```c + } else if (hdmi->version >= 0x200a) { + hdmi_writeb(hdmi, 0, HDMI_FC_SCRAMBLER_CTRL); } ``` The version guard `>= 0x200a` correctly matches the condition where the scrambler register exists. Carries Fixes tag and reviewed-by. No issues. --- Generated by Claude Code Patch Reviewer