From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi: Use of_device_get_match_data() to get match data Date: Sat, 16 May 2026 16:14:38 +1000 Message-ID: In-Reply-To: <20260510183114.1248840-2-jonas@kwiboo.se> References: <20260510183114.1248840-1-jonas@kwiboo.se> <20260510183114.1248840-2-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Clean** This replaces `of_match_node()` + `match->data` with the simpler `of_device_get_match_data()`. The early NULL check before allocation is a good improvement -- if the match table entry somehow lacks data, we bail before allocating. The `sizeof(*drv_data)` in the `devm_kmemdup` call is correct since `drv_data` is `const struct dw_hdmi_plat_data *`, same type as the old `sizeof(*plat_data)`. The removal of the `struct device_node *np = dev_of_node(dev)` variable is not done here but `np` is still used later, and the `of_device_get_match_data()` takes `dev` directly rather than `np`. The `np` NULL check remains, which is fine since it's used elsewhere. No issues. --- --- Generated by Claude Code Patch Reviewer