From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/rocket: fix ignored return value in rocket_ioctl_submit Date: Sat, 16 May 2026 16:08:43 +1000 Message-ID: In-Reply-To: <20260510200047.6117-1-contact.kartikn@gmail.com> References: <20260510200047.6117-1-contact.kartikn@gmail.com> <20260510200047.6117-1-contact.kartikn@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** The fix correctly captures the return value of `rock= et_ioctl_submit_job()` and breaks out of the loop on the first failure, pro= pagating the error to userspace via the existing `exit` label. The key code change: ```c - for (i =3D 0; i < args->job_count; i++) - rocket_ioctl_submit_job(dev, file, &jobs[i]); + for (i =3D 0; i < args->job_count; i++) { + ret =3D rocket_ioctl_submit_job(dev, file, &jobs[i]); + if (ret) + goto exit; + } ``` **No resource leak concerns.** Looking at `rocket_ioctl_submit_job()` (line= 533=E2=80=93588), it is fully self-contained with respect to resource mana= gement: on error, it cleans up the scheduler job and puts the job reference= before returning. On success, the job is pushed to the scheduler and also = properly ref-counted. So skipping subsequent jobs after a failure doesn't l= eak anything =E2=80=94 the `jobs` array is just userspace-copied data (`str= uct drm_rocket_job` values), freed at the `exit` label via `kvfree(jobs)`. **Pattern consistency.** The fix mirrors the error-handling style of the `c= opy_from_user` loop immediately above (lines 617=E2=80=93625), which also u= ses `goto exit` on failure. This is clean and consistent. **Commit message.** Clear and accurate. Describes the problem (ignored retu= rn value, silent error), the consequence (success returned to userspace, in= consistent state), and the fix (propagate error, break on failure). **Reviewed-by worthy.** No issues found. This is a straightforward, correct= bugfix. --- Generated by Claude Code Patch Reviewer