From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: leds: backlight: add Silergy SY7758 Date: Sat, 16 May 2026 16:17:41 +1000 Message-ID: In-Reply-To: <20260511-sy7758-v1-1-999a33081304@gmail.com> References: <20260511-sy7758-v1-0-999a33081304@gmail.com> <20260511-sy7758-v1-1-999a33081304@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The binding YAML and MAINTAINERS entry are clean and well-structured. **Minor issue =E2=80=94 example advertises properties the driver ignores:** The DT example includes `max-brightness` and `default-brightness` (inherite= d from `common.yaml`): ```yaml backlight@36 { compatible =3D "silergy,sy7758"; reg =3D <0x36>; max-brightness =3D <4080>; default-brightness =3D <1500>; }; ``` These properties are defined in the common schema so they're valid from a b= inding perspective, but the driver (patch 2) hardcodes `MAX_BRIGHTNESS` and= `DEFAULT_BRIGHTNESS` as `#define` constants and never reads them from DT. = Either the driver should consume these properties, or the example should no= t include them (to avoid misleading DT authors into thinking they're functi= onal). **Nit:** The binding looks good otherwise =E2=80=94 `allOf: - $ref: common.= yaml#`, `unevaluatedProperties: false`, required properties, and the MAINTA= INERS entry are all correct. --- --- Generated by Claude Code Patch Reviewer