From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exynos: fbdev: Remove offset into screen_buffer Date: Sat, 16 May 2026 15:38:04 +1000 Message-ID: In-Reply-To: <20260511115538.57884-2-tzimmermann@suse.de> References: <20260511115538.57884-1-tzimmermann@suse.de> <20260511115538.57884-2-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Good** This is a straightforward bugfix. The `screen_buffer` field in `struct fb_info` should point to the start of framebuffer memory, not to an offset within it. The `xoffset`/`yoffset` values describe scrolling during scanout and should not be baked into the base address. ```c - offset = fbi->var.xoffset * fb->format->cpp[0]; - offset += fbi->var.yoffset * fb->pitches[0]; ... - fbi->screen_buffer = exynos_gem->kvaddr + offset; + fbi->screen_buffer = exynos_gem->kvaddr; ``` The Fixes tag and stable Cc are appropriate. The offsets are typically 0 at fbdev setup time anyway (`drm_fb_helper_fill_info` sets `var.xoffset = var.yoffset = 0`), so this was mostly a latent bug rather than a functional regression, but still worth fixing for correctness. No concerns. --- --- Generated by Claude Code Patch Reviewer