From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/damage-helper: Do not alter damage clips on modeset, but ignore them Date: Sat, 16 May 2026 15:34:44 +1000 Message-ID: In-Reply-To: <20260511122421.114014-2-tzimmermann@suse.de> References: <20260511122421.114014-1-tzimmermann@suse.de> <20260511122421.114014-2-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correctness**: Good. Instead of freeing the `fb_damage_clips` blob (which was modifying userspace-supplied state behind the client's back), the code now just sets `ignore_damage_clips = true`. The damage iterator already respects this flag. The addition of `state->ignore_damage_clips = false` in `__drm_atomic_helper_plane_duplicate_state()` is a necessary bugfix -- without it, the flag could leak across state duplications. Correctly tagged with Fixes/Cc:stable. The new kunit test `drm_test_damage_iter_damage_ignore` is well-written and validates that two damage clips plus the ignore flag results in full-framebuffer damage. No issues. --- Generated by Claude Code Patch Reviewer