From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH 1/2] dt-bindings: display/bridge: lt9211: Add drive-strength-microamp property Date: Sat, 16 May 2026 13:11:28 +1000 Message-ID: In-Reply-To: <20260512-void-gravitate-68ebce8e76da@spud> References: <20260512164609.3390700-1-bstruempfel@data-modul.com> <20260512-void-gravitate-68ebce8e76da@spud> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Looks good.** The binding addition is well-formed. The enum lists 16 values matching the 16 hardware levels, and the default o= f 25 matches the existing hardcoded behavior. Placement within the `propert= ies:` block (between `vccio-supply` and `ports`) is reasonable. Minor points: 1. **Property name context**: `drive-strength-microamp` originates from the= pinctrl generic bindings (`pincfg-node.yaml`). Using it directly on a brid= ge device node is somewhat unusual. DT binding maintainers may prefer a ven= dor-prefixed property like `lontium,drive-strength-microamp`, or may be fin= e with it since the semantics are a natural fit. Worth confirming with Rob = Herring / Krzysztof. 2. **Units**: As noted above, 12-36 uA is extremely low for LVDS drive curr= ent. If these values actually represent milliamps, the property name and al= l values would need correction. The commit message says "12 uA to 36 uA" = =E2=80=94 please verify against the datasheet. 3. **Example DT**: The binding example does not show usage of the new prope= rty. While optional, adding `drive-strength-microamp =3D <25>;` to the exis= ting example would serve as documentation. --- Generated by Claude Code Patch Reviewer