From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Date: Sat, 16 May 2026 14:19:49 +1000 Message-ID: In-Reply-To: <20260512045454.1505733-1-wenst@chromium.org> References: <20260512045454.1505733-1-wenst@chromium.org> <20260512045454.1505733-1-wenst@chromium.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **EDID verification:** Both product IDs are correctly extracted from the pr= ovided raw EDIDs. AUO bytes `8f cb` =E2=86=92 0xcb8f and BOE bytes `25 0a` = =E2=86=92 0x0a25. Manufacturer IDs also decode correctly. **Sort order:** Both entries are inserted in the correct ascending order by= product ID: - AUO: 0xc9a8 < **0xcb8f** < 0xcdba =E2=9C=93 - BOE: 0x0a1b < **0x0a25** < 0x0a36 =E2=9C=93 **Delay structures:** ```c EDP_PANEL_ENTRY('A', 'U', 'O', 0xcb8f, &delay_200_500_e50, "B133HAN06.6"), ``` Uses `delay_200_500_e50` (hpd_absent=3D200, unprepare=3D500, enable=3D50) = =E2=80=94 a common default for AUO panels. Reasonable for a datasheet-only = entry, consistent with neighboring AUO entries that use the same delay. ```c EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a25, &delay_200_500_e50_po2e200, "NV133FH= M-N4F V8.0"), ``` Uses `delay_200_500_e50_po2e200`, which adds `powered_on_to_enable=3D200` o= n top of the base delays. Since this was hardware-tested, the choice of a d= elay with `powered_on_to_enable` is presumably validated. The nearby BOE en= try at 0x0a1b uses the simpler `delay_200_500_e50`, so the difference is in= tentional and worth noting =E2=80=94 the `powered_on_to_enable` delay likel= y reflects an observed requirement on this specific panel/board combination. **Minor observation (not blocking):** The AUO panel was not tested on hardw= are. The commit message is transparent about this ("solely based on the pro= vided datasheet"). If the delay turns out to be wrong, it can be adjusted l= ater =E2=80=94 standard practice for this table. **No issues found.** Reviewed-by would be appropriate. --- Generated by Claude Code Patch Reviewer