From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/loongson: use managed KMS polling Date: Sat, 16 May 2026 14:07:27 +1000 Message-ID: In-Reply-To: <20260512065436.74729-1-mhun512@gmail.com> References: <20260512065436.74729-1-mhun512@gmail.com> <20260512065436.74729-1-mhun512@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Code change:** ```c - drm_kms_helper_poll_init(ddev); + drmm_kms_helper_poll_init(ddev); ``` This is a clean one-line substitution. `drmm_kms_helper_poll_init()` is the= established managed wrapper (already used by `ast`, `hibmc`, and `udl` dri= vers in the tree), and it registers a cleanup action via `drmm_add_action_o= r_reset()` so that `drm_kms_helper_poll_fini()` is called automatically whe= n the DRM device is released. **Correctness:** The switch is safe here. `drmm_kms_helper_poll_init()` has= the same signature (takes only `struct drm_device *`). The managed cleanup= will run after `drm_dev_unregister()` tears down the device, which is the = correct ordering =E2=80=94 polling should be finalized after the device is = unregistered, and the `drmm` action ordering guarantees this since the poll= _init action is registered before `drm_dev_register()`. **Minor observation:** The commit message and Fixes tag are appropriate. Th= e `Cc: stable` tag is reasonable since this is a resource leak on error pat= hs that has existed since the driver was introduced. The Co-developed-by / = Signed-off-by chain is correctly formatted. **No issues found.**=20 Reviewed-by worthy as-is. --- Generated by Claude Code Patch Reviewer