From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Revert "i915: don't use a vma that didn't match the context VM" Date: Sat, 16 May 2026 13:59:28 +1000 Message-ID: In-Reply-To: <20260512085848.208008-1-joonas.lahtinen@linux.intel.com> References: <20260512085848.208008-1-joonas.lahtinen@linux.intel.com> <20260512085848.208008-1-joonas.lahtinen@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: OK** The patch removes: ```c else vma =3D NULL; ``` from the `eb_lookup_vma()` function in `i915_gem_execbuffer.c`. This is correct because: 1. `radix_tree_lookup()` returns `void *` and yields `NULL` when the entry = is not found (declared in `include/linux/radix-tree.h`). So when the `if (l= ikely(vma))` test falls through, `vma` is already `NULL`. 2. `i915_vma_tryget()` (defined in `i915_vma.h:194`) also returns `NULL` on= failure (when `kref_get_unless_zero` fails), so even after the `if (likely= (vma))` =E2=86=92 `i915_vma_tryget(vma)` path, a failure still leaves `vma`= as `NULL`. 3. After the removed `else` branch, the code proceeds to `if (likely(vma)) = return vma;` =E2=80=94 which correctly handles the `NULL` case regardless. **Commit message: Good.** References the original commit hash, links the re= levant lore discussion with Linus, and explains why the original commit was= a no-op. The Cc list is appropriate =E2=80=94 includes the original partic= ipants in the discussion. **Style: Fine.** A straightforward revert with `git revert` formatting. **No concerns.** This is a clean, well-justified removal of dead code. --- Generated by Claude Code Patch Reviewer