From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/adreno/a6xx: Mark cxpd device_link as stateless Date: Sat, 16 May 2026 12:47:07 +1000 Message-ID: In-Reply-To: <20260513-gmu-sync-state-fix-v1-1-6e33e6aa9b4f@oss.qualcomm.com> References: <20260513-gmu-sync-state-fix-v1-0-6e33e6aa9b4f@oss.qualcomm.com> <20260513-gmu-sync-state-fix-v1-1-6e33e6aa9b4f@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Looks good.** The cxpd virtual device has no real driver, so `device_links_driver_bound()` warns when the GMU driver binds and finds a managed (non-stateless) device_link pointing to a supplier without a driver. Adding `DL_FLAG_STATELESS` is the correct fix since the link's lifecycle is already managed manually by the MSM driver. ```c + if (!device_link_add(gmu->dev, gmu->cxpd, + DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS)) { ``` The same fix is applied consistently to both `a6xx_gmu_wrapper_init` and `a6xx_gmu_init`. The Fixes tag referencing `ead5d3e5eb37` is appropriate. Minor: The commit message explains the fix well, and the stack trace included makes the problem clear. --- --- Generated by Claude Code Patch Reviewer