From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: tc358762: Clean up register defines Date: Sat, 16 May 2026 12:04:21 +1000 Message-ID: In-Reply-To: <20260513-tc358762-fixes-v3-1-6698b55008b9@ideasonboard.com> References: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> <20260513-tc358762-fixes-v3-1-6698b55008b9@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Straightforward rename of magic constants to proper `BIT()` and register-pr= efixed defines. `PPI_START_FUNCTION` =E2=86=92 `PPI_STARTPPI_STARTPPI`, `DS= I_RX_START` =E2=86=92 `DSI_STARTDSI_STARTDSI`, and `LANEENABLE_*` =E2=86=92= `DSI_LANEENABLE_*`. The naming `PPI_STARTPPI_STARTPPI` and `DSI_STARTDSI_STARTDSI` is a bit stu= ttery but follows the convention of `REGISTER_FIELD`, which is standard for= register-prefixed defines when the field name matches the register name (c= ommon in Toshiba datasheets). No issues. **Reviewed-by worthy.** --- Generated by Claude Code Patch Reviewer