From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/loongson: Use managed KMS polling Date: Sat, 16 May 2026 12:30:13 +1000 Message-ID: In-Reply-To: <20260513065706.23803-1-mhun512@gmail.com> References: <20260513065706.23803-1-mhun512@gmail.com> <20260513065706.23803-1-mhun512@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: No issues.** The change from: ```c - drm_kms_helper_poll_init(ddev); + drmm_kms_helper_poll_init(ddev); ``` is the right fix. `drmm_kms_helper_poll_init()` is declared in `drm/drm_pro= be_helper.h` and registers a managed cleanup action via `drmm_add_action_or= _reset()`, so `drm_kms_helper_poll_fini()` is called automatically when the= DRM device is released. Looking at the probe function, the error paths at lines 300-301 and 308-310= return directly without any cleanup of the poll init =E2=80=94 this patch = fixes those leaks. The removal path in `lsdc_pci_remove()` also lacks a `dr= m_kms_helper_poll_fini()` call, which is likewise fixed by this change. **Tags:** The patch has appropriate `Fixes:`, `Cc: stable`, `Reviewed-by` (= Thomas Zimmermann, Huacai Chen), and `Acked-by` (Jianmin Lv) tags. **Nit (non-blocking):** The return type of `drmm_kms_helper_poll_init()` is= `void`, so there's no error to check =E2=80=94 the current usage is correc= t. **Verdict: Looks good.** No changes needed. --- Generated by Claude Code Patch Reviewer