From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: rockchip: analogix-dp: Fix hclk as third clock for RK3588 Date: Sat, 16 May 2026 12:26:16 +1000 Message-ID: In-Reply-To: <20260513074414.2053435-2-damon.ding@rock-chips.com> References: <20260513074414.2053435-1-damon.ding@rock-chips.com> <20260513074414.2053435-2-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good** Replaces the generic `clock-names` items list with per-compatible `if/then` blocks, allowing each SoC to specify its own third clock name. RK3288 gets 2 clocks (`dp`, `pclk`), RK3399 gets 3 (`dp`, `pclk`, `grf`), and RK3588 gets 3 (`dp`, `pclk`, `hclk`). The approach is correct -- the old generic binding forced `grf` as the third clock name, which is wrong for RK3588 (it needs `hclk`). Minor note: the `Fixes:` tag is appropriate since the existing binding claimed `grf` as the third clock for all compatibles, including RK3588 which needs `hclk`. --- Generated by Claude Code Patch Reviewer