From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/nouveau/fifo/nv04: filter benign CACHE_ERROR from Mesa NV50 bind probe Date: Sat, 16 May 2026 11:34:49 +1000 Message-ID: In-Reply-To: <20260513175014.96599-2-marek@czernohous.de> References: <20260513175014.96599-1-marek@czernohous.de> <20260513175014.96599-2-marek@czernohous.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Assessment: Good =E2=80=94 minor nits only.** The filter is narrowly scoped and well-explained. It checks for the exact M= esa NV50 bind probe signature (method 0x0060, data 0xbeef02xx) and demotes = only that case to debug level. **Positive:** By placing the filter *before* the `else` branch that patch 2= hooks into, benign probes correctly don't count toward the Tier-2 wedge wi= ndow. This is the right ordering. **Nit 1 =E2=80=94 debug message omits channel name.** The error path prints= `chan->name` but the debug path does not: ```c nvkm_debug(subdev, "CACHE_ERROR - ch %d subc %d mthd %04x data %08x (benign= , skipped)\n", chid, (mthd >> 13) & 7, mthd & 0x1ffc, data); ``` This is fine for a debug-level message, but for consistency with the error = message format (`ch %d [%s]`), consider including the channel name. Very mi= nor. **Nit 2 =E2=80=94 comment length.** The 5-line comment block is somewhat ve= rbose for a simple filter. The kernel style generally prefers shorter inlin= e comments. Not a blocker. --- --- Generated by Claude Code Patch Reviewer