From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: hecubafb: fix potential memory leak in hecubafb_probe() Date: Sat, 16 May 2026 11:10:40 +1000 Message-ID: In-Reply-To: <20260514-fbdev-v1-1-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> <20260514-fbdev-v1-1-b3a2474fa720@cse.iitm.ac.in> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Correct** The patch captures the return value of `fb_deferred_io_init()` and adds a new error label `err_fbdefio` that skips `fb_deferred_io_cleanup()` (since init failed), and adds `fb_deferred_io_cleanup()` to the existing `err_fbreg` fallthrough path: ```c - fb_deferred_io_init(info); + retval = fb_deferred_io_init(info); + if (retval) + goto err_fbdefio; ``` ```c err_fbreg: + fb_deferred_io_cleanup(info); +err_fbdefio: framebuffer_release(info); ``` The error ordering is correct: if `fb_deferred_io_init()` fails, we skip cleanup and go directly to `framebuffer_release()`. If `register_framebuffer()` fails, we call `fb_deferred_io_cleanup()` first, then release the framebuffer. The Fixes tag and stable Cc are appropriate. --- --- Generated by Claude Code Patch Reviewer