From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel: Add Chipone ICNA 35xx OLED driver bindings Date: Sat, 16 May 2026 10:37:00 +1000 Message-ID: In-Reply-To: <20260514-icna35xx-v2-1-45acd1dfa566@gmail.com> References: <20260514-icna35xx-v2-0-45acd1dfa566@gmail.com> <20260514-icna35xx-v2-1-45acd1dfa566@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch adds the YAML DT binding for `chipone,icna35xx.yaml`. **Generally looks good.** The binding correctly uses the two-level compatible scheme (board-specific + chip-generic fallback). A few minor observations: 1. **Non-standard supply names lack descriptions.** `disp-supply` and `blvdd-supply` are not common names. While `vdd`, `vddio`, and `vci` are well-known, these two would benefit from brief descriptions explaining what they power: ```yaml disp-supply: true blvdd-supply: true ``` Consider adding something like: ```yaml disp-supply: description: Display bias voltage supply blvdd-supply: description: Backlight LED voltage supply ``` 2. The example is clean and follows conventions. The `port` property is optional, which is fine. No blocking issues. --- --- Generated by Claude Code Patch Reviewer