From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fastrpc: Reduce log level for DSP info and reserved memory messages
Date: Sat, 16 May 2026 11:18:47 +1000 [thread overview]
Message-ID: <review-patch1-20260514062825.50172-1-jianping.li@oss.qualcomm.com> (raw)
In-Reply-To: <20260514062825.50172-1-jianping.li@oss.qualcomm.com>
Patch Review
**Hunk 1 (line ~1804): DSP information error → dev_dbg**
```c
} else if (err) {
dev_dbg(&cctx->rpdev->dev, "Error: dsp information is incorrect err: %d\n", err);
```
This path is reached from `fastrpc_get_dsp_info()` (line 1836), which is an ioctl handler — so this is user-triggerable. That actually supports the downgrade: a `dev_err` on a user-triggerable path can be used to flood the kernel log. However, this is also a genuine error return path (the function returns `err` to the caller), not just a "try again later" situation.
- **Nit**: The message string still says `"Error: ..."` which is slightly odd for a `dev_dbg` message. If the intent is that this is an expected/transient condition, consider rewording to something like `"failed to get dsp info, err: %d\n"`. But this is cosmetic.
- **Potential concern**: The commit message says this happens "temporarily during boot" — if it only happens during boot and self-resolves, `dev_dbg` is fine. But if the DSP never comes up and this error persists, having it at `dev_dbg` means an operator will see no indication of the problem unless dynamic debug is enabled. A possible alternative would be `dev_info_ratelimited()` to reduce flood while keeping visibility, but the author knows their platform better than I do and `dev_dbg` is a defensible choice given the ioctl-triggerable nature.
**Hunk 2 (line ~2363): Reserved DMA memory → dev_dbg**
```c
if (of_reserved_mem_device_init_by_idx(rdev, rdev->of_node, 0))
dev_dbg(rdev, "no reserved DMA memory for FASTRPC\n");
```
This is in the probe path (`fastrpc_rpmsg_probe`). The original `dev_info` is reasonable to downgrade — the commit message correctly notes that lack of reserved DMA memory is a valid configuration, not an error. The probe continues regardless of this result, so the message is purely informational. `dev_dbg` is appropriate here.
**Verdict**: The patch is correct and reasonable. The only suggestion is cosmetic (dropping the "Error:" prefix from the `dev_dbg` string in hunk 1). No objections to merging.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-16 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 6:28 [PATCH] fastrpc: Reduce log level for DSP info and reserved memory messages Jianping Li
2026-05-16 1:18 ` Claude review: " Claude Code Review Bot
2026-05-16 1:18 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260514062825.50172-1-jianping.li@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox