public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: rockchip: analogix-dp: Expose inherited properties
Date: Sat, 16 May 2026 11:13:13 +1000	[thread overview]
Message-ID: <review-patch1-20260514070133.2275069-2-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260514070133.2275069-2-damon.ding@rock-chips.com>

Patch Review

**Status: Looks correct.**

This patch adds `true` declarations for properties inherited from the base `analogix,dp.yaml` schema to satisfy `unevaluatedProperties: false` in the Rockchip binding file. The properties exposed (`reg`, `interrupts`, `phys`, `phy-names`, `force-hpd`, `ports`) all exist in the parent schema and are already used in the example DT node at the bottom of the file (e.g., `reg`, `interrupts`, `phys`, `phy-names`).

```yaml
+  reg: true
+  interrupts: true
+  phys: true
+  phy-names: true
+  force-hpd: true
+  ports: true
```

This is a straightforward schema fix. It's technically a prerequisite for the series (since patch 2 modifies the parent schema), but it's also a valid standalone fix — these properties should have been listed already given the `unevaluatedProperties: false` constraint.

No issues.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  1:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  7:01 [PATCH v1 0/3] Add eDP lane mapping support Damon Ding
2026-05-14  7:01 ` [PATCH v1 1/3] dt-bindings: display: rockchip: analogix-dp: Expose inherited properties Damon Ding
2026-05-14 18:16   ` Conor Dooley
2026-05-15  3:57     ` Damon Ding
2026-05-15  9:04       ` Conor Dooley
2026-05-16  1:13   ` Claude Code Review Bot [this message]
2026-05-14  7:01 ` [PATCH v1 2/3] dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint Damon Ding
2026-05-14 18:19   ` Conor Dooley
2026-05-15  2:53     ` Damon Ding
2026-05-16  1:13   ` Claude review: " Claude Code Review Bot
2026-05-14  7:01 ` [PATCH v1 3/3] drm/bridge: analogix_dp: Add support for optional data-lanes mapping Damon Ding
2026-05-16  1:13   ` Claude review: " Claude Code Review Bot
2026-05-16  1:13 ` Claude review: Add eDP lane mapping support Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260514070133.2275069-2-damon.ding@rock-chips.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox