From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbcon: Use correct type for vc_resize() return value Date: Sat, 16 May 2026 11:04:07 +1000 Message-ID: In-Reply-To: <20260514091918.1607234-1-yujiacheng3@huawei.com> References: <20260514091918.1607234-1-yujiacheng3@huawei.com> <20260514091918.1607234-1-yujiacheng3@huawei.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Assessment: Correct and clean.** The change is straightforward: ```c - int rows, cols; - unsigned long ret =3D 0; + int rows, cols, ret; ``` This is the right fix. `vc_resize()` is declared in `include/linux/vt_kern.= h:46` as returning `int`, so `ret` should be `int`. The usage at line 1494-= 1496 is: ```c ret =3D vc_resize(vc, cols, rows); if (con_is_visible(vc) && !ret) update_screen(vc); ``` The `!ret` check works identically for both types when the value comes from= `vc_resize()`, so this is purely a type-correctness fix with no behavioral= change. The `=3D 0` initializer is correctly dropped since `ret` is always= assigned before use (at line 1494), and every path that reaches line 1494 = will set it. **Minor nit on the Fixes tag:** The commit message claims `Fixes: af0db3c1f= 898 ("fbdev: Fix vmalloc out-of-bounds write in fast_imageblit")`. That com= mit title is about `fast_imageblit`, which seems unrelated to the `unsigned= long ret` declaration in `fbcon_set_disp()`. I'd recommend the author doub= le-check that the Fixes tag points to the correct commit =E2=80=94 it shoul= d point to whichever commit introduced the `unsigned long ret` variable in = this function. If it was always `unsigned long` since the function's incept= ion, a Fixes tag may not be appropriate at all (a simple cleanup doesn't ne= cessarily need one). **No other issues.** The patch is minimal, correctly scoped, and the commit= message accurately describes the warning being fixed. --- Generated by Claude Code Patch Reviewer