From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: remove unneeded get_gsp_info proxy function Date: Sat, 16 May 2026 09:54:07 +1000 Message-ID: In-Reply-To: <20260515-nova-unload-v5-1-c4d6250ad160@nvidia.com> References: <20260515-nova-unload-v5-0-c4d6250ad160@nvidia.com> <20260515-nova-unload-v5-1-c4d6250ad160@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean and correct. Makes `GetGspStaticInfo` `pub(crate)` and replaces the `get_gsp_info()` wrapper with a direct `cmdq.send_command()` call. ```rust -struct GetGspStaticInfo; +pub(crate) struct GetGspStaticInfo; ``` and at the call site: ```rust -let info = commands::get_gsp_info(&self.cmdq, bar)?; +let info = self.cmdq.send_command(bar, commands::GetGspStaticInfo)?; ``` The removed `Bar0` import is correct since it was only needed for the proxy function's signature. No issues. --- --- Generated by Claude Code Patch Reviewer