Claude review: video: fbdev: sm712: Fix operator precedence in big_swap macro

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Status: Correct fix for a real bug.**

The commit message clearly explains the problem: C operator precedence means `<<` and `>>` bind tighter than `&`, so the original code:

```c
#define big_swap(p)		((p & 0xff00ff00 >> 8) | (p & 0x00ff00ff << 8))
```

was parsed as:

```c
((p & (0xff00ff00 >> 8)) | (p & (0x00ff00ff << 8)))
```

which is `((p & 0x00ff00ff) | (p & 0xff00ff00))` — effectively just `p` (identity), completely defeating the byte swap.

The fix:

```c
#define big_swap(p)		(((p & 0xff00ff00) >> 8) | ((p & 0x00ff00ff) << 8))
```

correctly masks first, then shifts, implementing a proper swap of the high and low bytes within each 16-bit half of a 32-bit value.

**Verification:** All three call sites in `sm712fb.c` (lines 1010, 1069, 1141) use this for big-endian palette and framebuffer operations. The fix restores the intended byte-swap behavior that has been broken since the original merge.

**Nit (not blocking):** The macro argument `p` is not wrapped in parentheses (e.g., `(p)`) to guard against complex expressions. Since all current callers pass simple lvalues, this is a pre-existing cosmetic issue and not worth blocking the fix.

**Verdict: Reviewed-by worthy.** The Fixes tag correctly identifies the originating commit, and the fix is minimal and correct.

---
Generated by Claude Code Patch Reviewer