From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vblank: Add drmm_vblank_init() to indicate managed cleanup
Date: Sat, 16 May 2026 09:20:27 +1000
Message-ID: <review-patch1-20260515120916.333614-2-tzimmermann@suse.de>
In-Reply-To: <20260515120916.333614-2-tzimmermann@suse.de>
References: <20260515120916.333614-1-tzimmermann@suse.de> <20260515120916.333614-2-tzimmermann@suse.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

This patch renames `drm_vblank_init()` to `drmm_vblank_init()` to reflect that it already uses managed (drmm) cleanup, adds a `flags` argument, and keeps the old name as a static inline wrapper.

**Looks good overall.** The rename correctly follows DRM conventions for managed functions. Minor issues:

- The new `flags` field added to `struct drm_vblank_crtc` lacks kernel-doc:
```c
	struct drm_vblank_crtc_timer vblank_timer;

	unsigned int flags;
};
```
Should have at minimum:
```c
	/** @flags: flags for vblank handling (DRM_VBLANK_FLAG_*) */
	unsigned int flags;
```

- The internal release function rename from `drm_vblank_init_release` to `drmm_vblank_init_release` is correct for consistency.

- The inline backward-compat wrapper is clean:
```c
static inline int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs)
{
	return drmm_vblank_init(dev, num_crtcs, 0);
}
```

---
Generated by Claude Code Patch Reviewer