From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: samsung-dsim: enable MFLUSH_VS for Exynos 7870 DSIM
Date: Sat, 16 May 2026 08:42:29 +1000 [thread overview]
Message-ID: <review-patch1-20260516-exynos-dsim-fixes-v2-1-db9bf96ae641@disroot.org> (raw)
In-Reply-To: <20260516-exynos-dsim-fixes-v2-1-db9bf96ae641@disroot.org>
Patch Review
**Verdict: Looks good.**
This patch fixes a regression introduced in v6.17 by commit `a36c533ad3e1`, which assumed MFLUSH_VS is active-low across all variants. On Exynos 7870 the bit is active-high, so the bit must be explicitly set.
The fix is minimal and correctly scoped — it adds a hw_type check inside the existing video-mode configuration block:
```c
if (dsi->plat_data->hw_type == DSIM_TYPE_EXYNOS7870)
reg |= DSIM_MFLUSH_VS;
```
The downstream kernel reference is provided and the patch carries both Tested-by and stable Cc tags, which is appropriate for a regression fix. The comment is adequate. No issues found.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-15 22:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 21:44 [PATCH RESEND v2 0/2] Fixes and enhancements for Exynos (7870) DSIM bridge driver Kaustabh Chakraborty
2026-05-15 21:44 ` [PATCH RESEND v2 1/2] drm/bridge: samsung-dsim: enable MFLUSH_VS for Exynos 7870 DSIM Kaustabh Chakraborty
2026-05-15 22:42 ` Claude Code Review Bot [this message]
2026-05-15 21:44 ` [PATCH RESEND v2 2/2] drm/bridge: samsung-dsim: use DSIM interrupt to wait for PLL stability Kaustabh Chakraborty
2026-05-15 22:42 ` Claude review: " Claude Code Review Bot
2026-05-15 22:42 ` Claude review: Fixes and enhancements for Exynos (7870) DSIM bridge driver Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-22 17:02 [PATCH RESEND v2 0/2] " Kaustabh Chakraborty
2026-03-22 17:02 ` [PATCH RESEND v2 1/2] drm/bridge: samsung-dsim: enable MFLUSH_VS for Exynos 7870 DSIM Kaustabh Chakraborty
2026-03-24 22:14 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260516-exynos-dsim-fixes-v2-1-db9bf96ae641@disroot.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox