From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: bridge: dw_hdmi: Disable scrambler feature when not supported
Date: Mon, 18 May 2026 16:41:45 +1000
Message-ID: <review-patch1-20260516183838.2024991-2-jonas@kwiboo.se>
In-Reply-To: <20260516183838.2024991-2-jonas@kwiboo.se>
References: <20260516183838.2024991-1-jonas@kwiboo.se> <20260516183838.2024991-2-jonas@kwiboo.se>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Status:** Looks correct. Tagged with `Fixes:`.

When switching from a sink that requires scrambling (HDMI 2.0 4K@60) to one that doesn't support SCDC, the scrambler was left enabled, causing blank screens. The fix:

```c
+	} else if (hdmi->version >= 0x200a) {
+		hdmi_writeb(hdmi, 0, HDMI_FC_SCRAMBLER_CTRL);
	}
```

Correctly gates on `version >= 0x200a` (matching the existing SCDC support check above). Simple and correct fix.

---
Generated by Claude Code Patch Reviewer