From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: leds: Document TI LM3533 LED controller
Date: Mon, 18 May 2026 16:19:46 +1000
Message-ID: <review-patch1-20260517074306.30937-2-clamor95@gmail.com>
In-Reply-To: <20260517074306.30937-2-clamor95@gmail.com>
References: <20260517074306.30937-1-clamor95@gmail.com> <20260517074306.30937-2-clamor95@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

The bindings are mostly well-structured, but have some issues:

**Overly restrictive required list**: The top-level binding requires ALL child nodes:
```yaml
required:
  - compatible
  - reg
  - light-sensor
  - backlight@0
  - backlight@1
  - led@2
  - led@3
  - led@4
  - led@5
```
Not every board will use all six control banks plus ALS. Most real boards will only use a subset. This should use `patternProperties` matching without making every child `required`, or at minimum reduce the required set to just `compatible` and `reg`.

**`led-sources` maximum off-by-one in leds binding**: The `ti,lm3533-leds.yaml` defines `items: maximum: 5`, but the LVLED indices are 0-4, so the maximum should be `4`:
```yaml
  led-sources:
    items:
      maximum: 5    # should be 4
```

**Minor**: The `ti,resistor-ohm` property description says "resister" instead of "resistor."

---
Generated by Claude Code Patch Reviewer