From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tegra: gr2d/gr3d: Initialize address register map before HOST1X client is registered Date: Mon, 18 May 2026 16:14:38 +1000 Message-ID: In-Reply-To: <20260517091450.46728-2-clamor95@gmail.com> References: <20260517091450.46728-1-clamor95@gmail.com> <20260517091450.46728-2-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Assessment: Good, no issues.** This patch moves the `set_bit` loop that populates `addr_regs` from after `host1x_client_register()` to before it, in both gr2d.c and gr3d.c. The rationale is sound: `host1x_client_register()` can make the device available to userspace, and `gr2d_is_addr_reg()`/`gr3d_is_addr_reg()` consult `addr_regs` during job submission validation. An uninitialized bitmap would fail to flag address registers, potentially allowing userspace to bypass address relocation checks. The initialization depends only on the static `gr2d_addr_regs[]`/`gr3d_addr_regs[]` arrays and the already-allocated `gr2d->addr_regs`/`gr3d->addr_regs` bitmaps, so moving it earlier has no dependency issues. The diff for both files is symmetric and minimal. No concerns. --- Generated by Claude Code Patch Reviewer