From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vmwgfx: Fix hrtimer interrupt storm due to 0-period vblank Date: Mon, 25 May 2026 18:01:51 +1000 Message-ID: In-Reply-To: <20260518071741.441794-1-w15303746062@163.com> References: <20260518071741.441794-1-w15303746062@163.com> <20260518071741.441794-1-w15303746062@163.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Superseded by v2.** This patch targets the old code path in `vmw_vkms_ena= ble_vblank()` where the hrtimer was set up directly in the vmwgfx driver. T= he current tree has refactored this =E2=80=94 `vmw_vkms_enable_vblank()` no= w simply calls `drm_crtc_vblank_start_timer(crtc)` (vmwgfx_vkms.c:259), so = this patch no longer applies. Even if it did apply, fixing only in vmwgfx would leave other drivers using= `drm_crtc_vblank_start_timer()` (e.g., vkms) still vulnerable. The `WARN_ON_ONCE()` usage was also problematic =E2=80=94 it lets unprivile= ged userspace trigger a kernel warning, which is a panic on systems with `p= anic_on_warn=3D1`. **Verdict:** Correctly superseded by v2. --- Generated by Claude Code Patch Reviewer