From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: Fix missing pvr_power_fw_{en, dis}able() argument Date: Mon, 25 May 2026 22:56:24 +1000 Message-ID: In-Reply-To: <20260519131150.1290393-1-javierm@redhat.com> References: <20260519131150.1290393-1-javierm@redhat.com> <20260519131150.1290393-1-javierm@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** The fix adds the missing arguments with the correct = values: 1. **`pvr_power_fw_disable(pvr_dev, false, true)`** =E2=80=94 The third arg= ument `rpm_suspend=3Dtrue` is correct for the device suspend path. When `rp= m_suspend` is true, the function calls `disable_irq(pvr_dev->irq)` (line 11= 1 in pvr_power.c), which is the right thing to do during system suspend. Th= is is consistent with the non-suspend caller at line 548 which passes `rpm_= suspend=3Dfalse` (that's the reset path, where IRQ management is handled di= fferently). 2. **`pvr_power_fw_enable(pvr_dev, true)`** =E2=80=94 The argument `rpm_res= ume=3Dtrue` is correct for the device resume path. When `rpm_resume` is tru= e, the function calls `enable_irq(pvr_dev->irq)` (line 127), re-enabling th= e IRQ that was disabled during suspend. Again consistent with the reset cal= ler at line 571 which passes `false`. **Commit message: Good.** Includes the full build error output, clearly ide= ntifies the offending commit, and has a proper `Fixes:` tag. **Minor note:** The drm-next tree I checked already has the correct argumen= ts at these call sites but still uses `fw_dev.booted` rather than `fw_dev.i= nitialised`, suggesting the broken commit 42577ba79fbf hasn't landed there = yet (or this fix was already folded in via a different route). The patch's = `base-commit` and `branch: drm-misc-next` confirm it targets the tree where= the breakage exists. No issues found. This is a clean, obvious build fix. --- Generated by Claude Code Patch Reviewer