From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: Fix missing pvr_power_fw_{en, dis}able() argument Date: Mon, 25 May 2026 22:55:10 +1000 Message-ID: In-Reply-To: <20260519131239.1291732-1-javierm@redhat.com> References: <20260519131239.1291732-1-javierm@redhat.com> <20260519131239.1291732-1-javierm@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** The two changes match the function signatures exactly: 1. `pvr_power_fw_disable(pvr_dev, false, true)` =E2=80=94 adds the missing = `rpm_suspend` parameter. Passing `true` is correct because `pvr_power_devic= e_suspend()` is the system PM suspend path and needs the IRQ disabled (line= s 109-112 of `pvr_power.c` show `rpm_suspend=3Dtrue` calls `disable_irq()`)= . The `false` for `hard_reset` is also correct =E2=80=94 a suspend is not a= hard reset. 2. `pvr_power_fw_enable(pvr_dev, true)` =E2=80=94 adds the missing `rpm_res= ume` parameter. Passing `true` is correct because `pvr_power_device_resume(= )` is the system PM resume path and needs the IRQ re-enabled (line 126-127 = show `rpm_resume=3Dtrue` calls `enable_irq()`). These values are consistent with the existing (pre-regression) code in the = drm-next tree, where the same calls at lines 382 and 412 already have the c= orrect arguments. **Commit message: Good.** Includes the compiler error output, the `Fixes:` = tag pointing to the offending commit, and the `base-commit` / `branch` meta= data. **No issues found.** Reviewed-by would be appropriate here. --- Generated by Claude Code Patch Reviewer