From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/display: hdmi: Add common TMDS character rate constants
Date: Mon, 25 May 2026 22:44:49 +1000
Message-ID: <review-patch1-20260519144712.1418302-2-javierm@redhat.com>
In-Reply-To: <20260519144712.1418302-2-javierm@redhat.com>
References: <20260519144712.1418302-1-javierm@redhat.com> <20260519144712.1418302-2-javierm@redhat.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Adds four `#define` constants to `include/drm/display/drm_hdmi_helper.h`:

```c
#define DRM_HDMI_TMDS_CHAR_RATE_MIN      25000000
#define DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0  165000000
#define DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3  340000000
#define DRM_HDMI_TMDS_CHAR_RATE_MAX_2_0  600000000
```

The values are correct per the HDMI specifications. The naming convention `DRM_HDMI_TMDS_CHAR_RATE_MAX_<version>` is clear and consistent. The comment `/* HDMI spec TMDS character rate limits (in Hz) */` is appropriate. The placement before the struct forward declarations is fine.

**No issues.**

---

---
Generated by Claude Code Patch Reviewer