From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: only add colorop state from active color pipeline Date: Mon, 25 May 2026 22:24:20 +1000 Message-ID: In-Reply-To: <20260519211111.228303-2-mwen@igalia.com> References: <20260519211111.228303-1-mwen@igalia.com> <20260519211111.228303-2-mwen@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good** Changes `drm_atomic_add_affected_colorops()` to take `struct drm_plane_stat= e *` instead of `struct drm_atomic_commit *`, and walks only the active col= or pipeline chain (`plane_state->color_pipeline -> next -> next ...`) rathe= r than iterating all colorops globally. The early-out is clean: ```c if (!plane_state || !plane_state->color_pipeline) return 0; ``` The callers in `drm_atomic.c` and `drm_atomic_helper.c` are updated consist= ently =E2=80=94 the check for `plane_state->color_pipeline` is moved into t= he callee, simplifying call sites. The extra blank line removal in `drm_ato= mic_helper.c` (line 188) is cosmetic but harmless. No issues. --- --- Generated by Claude Code Patch Reviewer