From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Move fdlist to invoke context structure Date: Mon, 25 May 2026 22:12:29 +1000 Message-ID: In-Reply-To: <20260520065047.3415790-2-ekansh.gupta@oss.qualcomm.com> References: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> <20260520065047.3415790-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Overall: Looks good.** This patch moves the `fdlist` pointer from being recalculated in `fastrpc_p= ut_args()` to being stored in `struct fastrpc_invoke_ctx`. The pointer is c= omputed once in `fastrpc_get_args()` and reused later. The correctness relies on `ctx->nscalars` equaling `inbufs + outbufs + hand= les` =E2=80=94 which is confirmed by the `REMOTE_SCALARS_LENGTH` macro defi= nition: ```c ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); ``` This is equivalent to the original: ```c fdlist =3D (uint64_t *)(pages + inbufs + outbufs + handles); ``` The cleanup of the now-unused `outbufs`, `handles`, `list`, and `pages` var= iables in `fastrpc_put_args()` is correct. One minor nit: the patch also re= moves the blank line after `int ret =3D 0;` =E2=80=94 this creates an empty= blank line before the `for` loop, which is fine but cosmetic. **No issues found.** --- --- Generated by Claude Code Patch Reviewer