From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: fix kernel-doc warnings Date: Mon, 25 May 2026 21:16:18 +1000 Message-ID: In-Reply-To: <20260520183721.279669-1-rdunlap@infradead.org> References: <20260520183721.279669-1-rdunlap@infradead.org> <20260520183721.279669-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Clean / Reviewed-by worthy** **Change 1 =E2=80=94 Add `@power_module` doc (line 333 in the patched file)= :** ```c * @freesync_module: Module handling freesync calculations * @power_module: Manages replay, PSR, and backlight control functionality * @hdcp_workqueue: AMDGPU content protection queue ``` Verified: The struct member `struct mod_power *power_module;` exists at lin= e 579 of the patched file, and the new doc comment is placed in the correct= position matching the declaration order (after `freesync_module`, before `= hdcp_workqueue`). The description is accurate =E2=80=94 `mod_power` handles= PSR, replay, and backlight. Correct. **Change 2 =E2=80=94 Rename `@dm_boot_time_crc_info` to `@boot_time_crc_inf= o` (line 712 in the patched file):** ```c /** * @boot_time_crc_info: * * Buffer info for the boot time crc. */ struct dm_boot_time_crc_info boot_time_crc_info; ``` Verified: The struct member is `boot_time_crc_info` (line 716), not `dm_boo= t_time_crc_info`. The old doc tag `@dm_boot_time_crc_info` was a copy-paste= error from the type name `struct dm_boot_time_crc_info`. The fix correctly= makes the kernel-doc tag match the member name. Correct. **No issues. No nits.** The commit message clearly explains the problem (wi= th the actual warning text), the `Fixes:` tags are appropriate, and the Cc = list covers the relevant maintainers. --- Generated by Claude Code Patch Reviewer